Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SetIterKey/SetIterValue #5

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Use SetIterKey/SetIterValue #5

merged 1 commit into from
Jan 13, 2025

Conversation

bep
Copy link
Member

@bep bep commented Jan 12, 2025

Compared to previous commit:

       │ stash.bench │        fix-setiterval.bench        │
       │   sec/op    │   sec/op     vs base               │
Map-10   3.159µ ± 1%   2.609µ ± 1%  -17.44% (p=0.002 n=6)

       │ stash.bench │       fix-setiterval.bench        │
       │    B/op     │    B/op     vs base               │
Map-10   1360.0 ± 0%   752.0 ± 0%  -44.71% (p=0.002 n=6)

       │ stash.bench │       fix-setiterval.bench        │
       │  allocs/op  │ allocs/op   vs base               │
Map-10   128.00 ± 0%   90.00 ± 0%  -29.69% (p=0.002 n=6)

Compared to 1dee3c3:

       │ 1dee3c38213ce142b02cf6ede54e75d872f892df.bench │        fix-setiterval.bench        │
       │                     sec/op                     │   sec/op     vs base               │
Map-10                                      3.608µ ± 1%   2.537µ ± 1%  -29.68% (p=0.002 n=6)

       │ 1dee3c38213ce142b02cf6ede54e75d872f892df.bench │       fix-setiterval.bench        │
       │                      B/op                      │    B/op     vs base               │
Map-10                                      1888.0 ± 0%   752.0 ± 0%  -60.17% (p=0.002 n=6)

       │ 1dee3c38213ce142b02cf6ede54e75d872f892df.bench │       fix-setiterval.bench        │
       │                   allocs/op                    │ allocs/op   vs base               │
Map-10                                      130.00 ± 0%   90.00 ± 0%  -30.77% (p=0.002 n=6)

@bep
Use SetIterKey/SetIterValue
12f15ed 
Compared to previous commit:

```
       │ stash.bench │        fix-setiterval.bench        │
       │   sec/op    │   sec/op     vs base               │
Map-10   3.159µ ± 1%   2.609µ ± 1%  -17.44% (p=0.002 n=6)

       │ stash.bench │       fix-setiterval.bench        │
       │    B/op     │    B/op     vs base               │
Map-10   1360.0 ± 0%   752.0 ± 0%  -44.71% (p=0.002 n=6)

       │ stash.bench │       fix-setiterval.bench        │
       │  allocs/op  │ allocs/op   vs base               │
Map-10   128.00 ± 0%   90.00 ± 0%  -29.69% (p=0.002 n=6)
```

Compared to 1dee3c3:

```
       │ 1dee3c3.bench │        fix-setiterval.bench        │
       │                     sec/op                     │   sec/op     vs base               │
Map-10                                      3.608µ ± 1%   2.537µ ± 1%  -29.68% (p=0.002 n=6)

       │ 1dee3c3.bench │       fix-setiterval.bench        │
       │                      B/op                      │    B/op     vs base               │
Map-10                                      1888.0 ± 0%   752.0 ± 0%  -60.17% (p=0.002 n=6)

       │ 1dee3c3.bench │       fix-setiterval.bench        │
       │                   allocs/op                    │ allocs/op   vs base               │
Map-10                                      130.00 ± 0%   90.00 ± 0%  -30.77% (p=0.002 n=6)
````
@bep bep merged commit 18d2e7b into gohugoio:master Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bep