add signal handling for build #407
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteut
force-pushed
the
add-signal-support
branch
2 times, most recently
from
b432067 to
30c36a9
Compare
peteut
force-pushed
the
add-signal-support
branch
from
30c36a9 to
bf3e7f1
Compare
stapelberg
requested changes
Jan 27, 2022
| func main() { | ||
| defer func() { |
There was a problem hiding this comment.
Instead of using a custom fatal function, can you please refactor the code such that it returns an error from a new function that is called from main()?
| cancel() | ||
| log.Println("Stopping ...") | ||
| }() | ||
| signal.Notify(signalChan, syscall.SIGINT, syscall.SIGTERM) |
There was a problem hiding this comment.
Use signal.NotifyContext instead please
| rand.Seed(time.Now().UnixNano()) | ||
| randBytes := make([]byte, 4) | ||
| rand.Read(randBytes) | ||
| containerId := "compilekernel-" + hex.EncodeToString(randBytes) |
There was a problem hiding this comment.
Please put “gokrazy” in the name here, to make it a little more clear to users where the container came from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a patch which adds signal handing using
exec.CommandContext. Graceful shutdown of the container is achieved using the<executable> stop <name>command.As the implementation relies on
defer,log.Fatal{F}must be be used andfatalis used to allow fordefersupport.