Add OpenSearch Support to Golang Migrate #1175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfelisb
changed the title
|
Following this. |
digi0pz
reviewed
Oct 12, 2024
|
|
||
| const MigrationVersionDocId = "migration_version" // The id of a document used as a lock | ||
| const DefaultTimeout = 1 * time.Minute // Default operations timeout | ||
| const DefaultIndex = ".migrations" // Default index to handle migrations |
There was a problem hiding this comment.
Would it be a good idea to give the users the configuration to set the default index name?
There was a problem hiding this comment.
Hi, @digi0pz! It's possible by the standard conn string. opensearch://user:password@host:port/index
|
Hi, @dhui! Maybe can you help us with a review? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for OpenSearch as a new database driver in the migrate tool.
Key aspects of the implementation include:
database.Driverinterface.Run,Version,Drop, and etc methods using the OpenSearch API. PlusWithInstance.Lockmethod creates a unique entry in this index, ensuring only one migration runs at a time. It uses optimistic locking to prevent race conditions—if another process holds the lock, migration fails, maintaining data integrity.Note: It's highly recommended to thoroughly test this in a non-production environment first, as the user assumes full responsibility for its usage and outcome.