-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Build all Database and Source drivers by default #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1232 (comment)
package cli | ||
|
||
import ( | ||
_ "github.com/ClickHouse/clickhouse-go" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why this was needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from build_clickhouse.go.
migrate/internal/cli/build_clickhouse.go
Lines 5 to 8 in 9023d66
import ( | |
_ "github.com/ClickHouse/clickhouse-go" | |
_ "github.com/golang-migrate/migrate/v4/database/clickhouse" | |
) |
Building all drivers by default seems unfortunate, in particular in a workflow where everyone is compiling it (as happens with A simpler path might be moving |
Hi @abh ! Nice suggestion! One potential issue: This approach currently lacks multi-driver support. For example, projects needing both PostgreSQL + MongoDB would hit limitations. |
@yshngg how so? I tried it in one of my projects by just copying main.go, log.go and commands.go into a new package ( If the Ask
|
@abh apologies for the earlier misunderstanding! 🙏 Your idea is indeed viable, but I'm concerned it might add unnecessary complexity to our workflow with golang-migrate/migrate. @dhui , any thoughts? |
Support the new Go 1.24 feature: using
go tool
to track tool dependencies.Current:
Expected:
Go 1.24 Release Notes
Fix #1232