cmd/cgo: explicitly use void for functions with no parameters#70981
cmd/cgo: explicitly use void for functions with no parameters#70981mauri870 wants to merge 2 commits intogolang:masterfrom
Conversation
|
This PR (HEAD: 6663cca) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638635. Important tips:
|
|
Message from Mauri de Souza Meneguzzo: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-24T12:32:10Z","revision":"ea8e7471cdcbeea9766334a6d65dafa306a895f1"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
6663cca to
a07bd09
Compare
|
Message from Mauri de Souza Meneguzzo: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
This PR (HEAD: a07bd09) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638635. Important tips:
|
|
Message from Mauri de Souza Meneguzzo: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-24T13:16:07Z","revision":"278cf67e4e90e232aee9b9baa84292b31e2d2272"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Mauri de Souza Meneguzzo: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Ian Lance Taylor: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
Currently, exported Go functions with no parameters generate C functions with an empty parameter list. In C, a function with an empty parameter list can accept any number of arguments, whereas a function with a single void parameter explicitly declares that it takes no arguments. To align the generated C functions with their Go prototypes, update the code generation to explicitly include a void parameter for functions with no parameters. Change-Id: I6d813815228efda95a7a6a9bbf9c9a787ff4f420
a07bd09 to
67a8169
Compare
|
This PR (HEAD: 67a8169) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638635. Important tips:
|
|
Message from Mauri de Souza Meneguzzo: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Ian Lance Taylor: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-26T20:25:27Z","revision":"bde7d710601776c8e6e5c2ebc087793df99c0095"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Ian Lance Taylor: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
a6bded6 to
39678c4
Compare
39678c4 to
6ff21a9
Compare
|
This PR (HEAD: 6ff21a9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638635. Important tips:
|
|
Message from Mauri de Souza Meneguzzo: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-17T14:01:46Z","revision":"d2a218c74ae2c812e84e0ce93cc711d17572ee27"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Mauri de Souza Meneguzzo: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Mauri de Souza Meneguzzo: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Ian Lance Taylor: Patch Set 5: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-17T20:27:41Z","revision":"d2a218c74ae2c812e84e0ce93cc711d17572ee27"} Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Ian Lance Taylor: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
|
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/638635. |
Currently, exported Go functions with no parameters generate C functions with an empty parameter list. In C, a function with an empty parameter list can accept any number of arguments, whereas a function with a single void parameter explicitly declares that it takes no arguments. To align the generated C functions with their Go prototypes, update the code generation to explicitly include a void parameter for functions with no parameters. Fixes #68411 Change-Id: Iab9456aa0236200bf21d1181a2e18e82869df63f GitHub-Last-Rev: 6ff21a9 GitHub-Pull-Request: #70981 Reviewed-on: https://go-review.googlesource.com/c/go/+/638635 Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
|
This PR is being closed because golang.org/cl/638635 has been merged. |
Currently, exported Go functions with no parameters generate C functions with an empty parameter list. In C, a function with an empty parameter list can accept any number of arguments, whereas a function with a single void parameter explicitly declares that it takes no arguments. To align the generated C functions with their Go prototypes, update the code generation to explicitly include a void parameter for functions with no parameters. Fixes #68411 Change-Id: Iab9456aa0236200bf21d1181a2e18e82869df63f GitHub-Last-Rev: 6ff21a98dfef81df649c76221d9c0858dc0e35e1 GitHub-Pull-Request: golang/go#70981 Reviewed-on: https://go-review.googlesource.com/c/go/+/638635 Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
Currently, exported Go functions with no parameters generate C functions
with an empty parameter list. In C, a function with an empty parameter
list can accept any number of arguments, whereas a function with a single
void parameter explicitly declares that it takes no arguments.
To align the generated C functions with their Go prototypes, update the
code generation to explicitly include a void parameter for functions
with no parameters.
Fixes #68411