-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: respect -n flag in 'go tool' command #72902
base: master
Are you sure you want to change the base?
Conversation
Set BuildN to toolN to properly respect the -n flag in 'go tool' commands, preventing unnecessary builds when only printing commands.
This PR (HEAD: a8dd0ca) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/658395. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/658395. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/658395. |
Message from Kirtan Soni: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/658395. |
Message from Michael Matloob: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/658395. |
Message from Kirtan Soni: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/658395. |
Message from Kirtan Soni: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/658395. |
Message from Michael Matloob: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/658395. |
Message from Kirtan Soni: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/658395. |
This PR (HEAD: cb5699f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/658395. Important tips:
|
In 'go tool -n' command, '-n' flag wasn't being properly respected, causing the command to rebuild the package & store the cache every time. fix ensures that 'go tool -n' consistent with the documentation.
Fixes #72824