Skip to content

Commit

Permalink
x/review/git-codereview: Set git config commit.gpgsign to false
Browse files Browse the repository at this point in the history
Otherwise if commit.gpgsign is true in ~/.gitconfig,
the following error occurs:

error: There was a problem with the editor 'false'.
Please supply the message using either -m or -F option.

Fixes #67402
  • Loading branch information
hnakamur committed May 15, 2024
1 parent c91ae92 commit f4a4302
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions git-codereview/util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ func newGitTest(t *testing.T) (gt *gitTest) {
write(t, client+"/.git/hooks/"+h, "#!/bin/sh\nexit 0\n", 0755)
}

trun(t, client, "git", "config", "commit.gpgsign", "false")
trun(t, client, "git", "config", "core.editor", "false")
pwd, err := os.Getwd()
if err != nil {
Expand Down

0 comments on commit f4a4302

Please sign in to comment.