-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/text/message: fix language translation issue #47
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: a6f64bc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/text/+/530716. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/530716. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/530716. |
Message from Ian Lance Taylor: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/530716. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-09-23T14:50:32Z","revision":"80f335d4d48fae22106736bef21c6e378e1405de"} Please don’t reply on this GitHub thread. Visit golang.org/cl/530716. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/530716. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/x_text-gotip-linux-arm64 has failed with summary (view all results): failed to run "test golang.org/x/text module": exit status 1 Please don’t reply on this GitHub thread. Visit golang.org/cl/530716. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/530716. |
Problem golang/go#63173
The current iteration of the package designed for word translation, golang.org/x/text/message, is not working as expected. The problem lies in the fact that the package's translation functions are not correctly replacing words in the output string according to the specified language. This leads to incorrect results when trying to print messages in different languages.
Solution
I have identified the issue in the golang.org/x/text/message package where the translation functions do not properly replace words based on the specified language. In my commit, I propose a fix that addresses this problem and ensures that the translation functions work as expected.
This fix involves making modifications to the formatting methods of the Printer type, such as Sprint, Fprint, Sprintln and Fprintln, so that they correctly apply the translations based on the provided language. Additionally, I have tested the changes to ensure that they produce the expected results in different languages, as demonstrated in the code snippet above.