Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text/message: fix language translation issue #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tinkivink1
Copy link

@tinkivink1 tinkivink1 commented Sep 23, 2023

Problem golang/go#63173
The current iteration of the package designed for word translation, golang.org/x/text/message, is not working as expected. The problem lies in the fact that the package's translation functions are not correctly replacing words in the output string according to the specified language. This leads to incorrect results when trying to print messages in different languages.

Solution
I have identified the issue in the golang.org/x/text/message package where the translation functions do not properly replace words based on the specified language. In my commit, I propose a fix that addresses this problem and ensures that the translation functions work as expected.

This fix involves making modifications to the formatting methods of the Printer type, such as Sprint, Fprint, Sprintln and Fprintln, so that they correctly apply the translations based on the provided language. Additionally, I have tested the changes to ensure that they produce the expected results in different languages, as demonstrated in the code snippet above.

@gopherbot
Copy link
Contributor

This PR (HEAD: a6f64bc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/text/+/530716.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@tinkivink1 tinkivink1 changed the title Fix Language Translation Issue in message Package x/text/message: Fix Language Translation Issue in message Package Sep 23, 2023
@tinkivink1 tinkivink1 changed the title x/text/message: Fix Language Translation Issue in message Package x/text/message: fix Language Translation Issue in message Package Sep 23, 2023
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/530716.
After addressing review feedback, remember to publish your drafts!

@tinkivink1 tinkivink1 changed the title x/text/message: fix Language Translation Issue in message Package x/text/message: fix language translation issue Sep 23, 2023
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/530716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/530716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-23T14:50:32Z","revision":"80f335d4d48fae22106736bef21c6e378e1405de"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/530716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/530716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/x_text-gotip-linux-arm64 has failed with summary (view all results):


failed to run "test golang.org/x/text module": exit status 1


Please don’t reply on this GitHub thread. Visit golang.org/cl/530716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/530716.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants