src/goImpl: improve goimpl implememtations (#1547) #1592

day-dreams · 2021-06-25T09:26:28Z

change InputBox to QuickPick
search workspace interface symbol according to keyword
change static code text to code snippet

* change InputBox to QuickPick * search workspace interface symbol according to keyword * change static code text to code snippet

google-cla · 2021-06-25T09:26:45Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

day-dreams · 2021-06-25T09:29:24Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).

The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.

The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

gopherbot · 2021-06-25T09:35:43Z

This PR (HEAD: c2e17a3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330850 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-06-25T09:40:13Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-25T18:08:00Z

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-25T18:08:01Z

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/692ef3a8-9175-4633-8d7f-04430f98dfca

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-25T18:12:36Z

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/692ef3a8-9175-4633-8d7f-04430f98dfca

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-25T19:04:48Z

Message from Suzy Mueller:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

google-cla · 2021-06-26T13:37:00Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

* change InputBox to QuickPick * search workspace interface symbol according to keyword * change static code text to code snippet For golang#1547

gopherbot · 2021-06-26T13:39:14Z

This PR (HEAD: 3cd9332) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330850 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-06-26T13:46:16Z

Message from day-dreams:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-30T21:07:28Z

Message from Suzy Mueller:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-30T21:09:46Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/e1e16ec4-c86f-44d3-82c6-a9546346acf1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-30T21:12:11Z

Message from kokoro:

Patch Set 3: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/e1e16ec4-c86f-44d3-82c6-a9546346acf1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-26T10:53:26Z

This PR (HEAD: 3c9d035) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330850 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-11-08T11:00:43Z

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:44Z

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/692ef3a8-9175-4633-8d7f-04430f98dfca

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:45Z

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/692ef3a8-9175-4633-8d7f-04430f98dfca

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:46Z

Message from Suzy Mueller:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:47Z

Message from day-dreams:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:48Z

Message from Suzy Mueller:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:48Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/e1e16ec4-c86f-44d3-82c6-a9546346acf1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:49Z

Message from kokoro:

Patch Set 3: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/e1e16ec4-c86f-44d3-82c6-a9546346acf1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

Change-Id: I7e26f492e584088a5e06d12d46561038d1069914

Change-Id: I3f85a665b111fc043bf226965d917838831f990f

A space before Receiver__ makes the replacement never occurs. Change-Id: Ibf0ee8bfa0004b942243dfb50a8d97f5683896e5

Change-Id: I736fdc6946abb8f5e9df9710ed52631706b08da3

gopherbot · 2021-12-30T00:30:48Z

This PR (HEAD: 6994d90) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330850 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

If user searches with 'io.Reader' for more specific workspace symbol search, the new interface returns 'io.Reader' as the symbol name. Passing it to impl as it is will cause an error. Use only the part after '.' as a heuristic. Change-Id: I7935ad9ef59be50db0bc09890b9532c8e0ba32b6

gopherbot · 2021-12-30T01:18:11Z

This PR (HEAD: b2f06cc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330850 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

hyangah · 2021-12-30T01:44:21Z

@day-dreams Just in case you didn't see the comment in the gerrit cl. I added minor changes. Please take a look.

gopherbot · 2021-12-30T01:44:59Z

Message from Hyang-Ah Hana Kim:

Patch Set 6: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

Change-Id: I149d07ae251186898861089b66bee9ec5a57c7a7

gopherbot · 2021-12-30T03:18:42Z

This PR (HEAD: 11dd0ec) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330850 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-12-30T03:28:54Z

Message from Hyang-Ah Hana Kim:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-12-30T03:34:56Z

Message from kokoro:

Patch Set 7:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/067ec8bf-5d9c-4de4-aa74-663a20794c20

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-12-30T03:43:52Z

Message from kokoro:

Patch Set 7: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/067ec8bf-5d9c-4de4-aa74-663a20794c20

Please don’t reply on this GitHub thread. Visit golang.org/cl/330850.
After addressing review feedback, remember to publish your drafts!

FernandoBasso · 2024-10-31T11:34:56Z

Why hasn't this been merged yet?

Improve goimpl implememtations (golang#1547)

c2e17a3

* change InputBox to QuickPick * search workspace interface symbol according to keyword * change static code text to code snippet

google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Jun 25, 2021

google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jun 25, 2021

day-dreams mentioned this pull request Jun 25, 2021

Add Package/Interface Dropdowns to Generate Interface Stubs Command #1547

Open

google-cla bot added cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. and removed cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. labels Jun 26, 2021

src/goImpl.ts: improve goimp implementations

3cd9332

* change InputBox to QuickPick * search workspace interface symbol according to keyword * change static code text to code snippet For golang#1547

day-dreams force-pushed the master branch from 7f57be6 to 3cd9332 Compare June 26, 2021 13:38

google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jun 26, 2021

hyangah changed the title ~~Improve goimpl implememtations (#1547)~~ src/goImpl: improve goimpl implememtations (#1547) Jun 30, 2021

Merge branch 'golang:master' into master

3c9d035

hyangah added 4 commits December 29, 2021 18:19

Merge branch 'master' into pr1592

f2bd27a

Change-Id: I7e26f492e584088a5e06d12d46561038d1069914

.vscode/launch.json: recover launch.json

4776a3d

Change-Id: I3f85a665b111fc043bf226965d917838831f990f

src/goImpl: remove unnecessary replacement

368a049

A space before Receiver__ makes the replacement never occurs. Change-Id: Ibf0ee8bfa0004b942243dfb50a8d97f5683896e5

package.json: npm install lodash

6994d90

Change-Id: I736fdc6946abb8f5e9df9710ed52631706b08da3

typings/lodash.d.ts: remove ancient copy of lodash.d.ts

11dd0ec

Change-Id: I149d07ae251186898861089b66bee9ec5a57c7a7

src/goImpl: improve goimpl implememtations (#1547) #1592

Are you sure you want to change the base?

src/goImpl: improve goimpl implememtations (#1547) #1592

Conversation

day-dreams commented Jun 25, 2021 • edited by hyangah Loading

google-cla bot commented Jun 25, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

day-dreams commented Jun 25, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

google-cla bot commented Jun 26, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jul 26, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Dec 30, 2021

gopherbot commented Dec 30, 2021

hyangah commented Dec 30, 2021

gopherbot commented Dec 30, 2021

gopherbot commented Dec 30, 2021

gopherbot commented Dec 30, 2021

gopherbot commented Dec 30, 2021

gopherbot commented Dec 30, 2021

FernandoBasso commented Oct 31, 2024

day-dreams commented Jun 25, 2021 •

edited by hyangah

Loading