-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug: respect go test flags usage #2428
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: fe6720d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from Jamal Carvalho: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from kokoro: Patch Set 2: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from kokoro: Patch Set 2: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from Jamal Carvalho: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
This PR (HEAD: dd931e4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it. Tip: You can toggle comments from me using the |
Message from leo steve: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from Hyang-Ah Hana Kim: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from kokoro: Patch Set 3: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from kokoro: Patch Set 3: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
This PR (HEAD: 42ec3e8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it. Tip: You can toggle comments from me using the |
Message from leo steve: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from Jamal Carvalho: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from kokoro: Patch Set 4: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from kokoro: Patch Set 4: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
This PR (HEAD: 98a9bdb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it. Tip: You can toggle comments from me using the |
Message from leo steve: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from Jamal Carvalho: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from leo steve: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from leo steve: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from Jamal Carvalho: Patch Set 5: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from kokoro: Patch Set 5: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
Message from kokoro: Patch Set 5: TryBot-Result+1 Kokoro presubmit build finished with status: SUCCESS Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. |
This was never merged. #1831 is still open. It really looks like this will fix it. Any chance of some help form the team here? |
I also ran into this issue, on a CGO project which requires ldflags+extflags on macOS. The impact is that my project cannot test or debug tests on VSC on macOS. |
This PR (HEAD: cc35f55) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/425835. Important tips:
|
This PR (HEAD: f9633df) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/425835. Important tips:
|
The
go test
require the package list appear before any flag unknown to thego test
command.But
vscode-go
constructs arguments for the go test call withtestify
that doesn't respect the usage.This PR fixes this problem by filling in the package list first.
Fixes: #1831