Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge after 1.2] include openapi yaml in client crate #1418

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Merge after 1.2] include openapi yaml in client crate #1418

wants to merge 8 commits into from

Conversation

mschuwalow
Copy link
Contributor

No description provided.

@mschuwalow mschuwalow changed the title include openapi yaml in client crate [Merge after 1.2] include openapi yaml in client crate Mar 14, 2025
Base automatically changed from plugin-tests to main March 14, 2025 17:03
vigoo
vigoo requested changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@vigoo vigoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will break publishing, because it refers to something outside of the crate root. That's why for example in wasm-rpc the WITs included are copied (duplicated) by a cargo make step

@mschuwalow
Copy link
Contributor Author

This is the one within the crate.
Include bytes takes a relative path https://doc.rust-lang.org/std/macro.include_bytes.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigoo vigoo vigoo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschuwalow @vigoo