Minor: Worker files - List file as part of list_directory #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschuwalow
reviewed
Jul 17, 2025
mschuwalow
reviewed
Jul 17, 2025
mschuwalow
approved these changes
Jul 20, 2025
|
@mschuwalow I am still not done, there is a small bug in how file gets passed through worker-executor and then worker-service |
Nanashi-lab
commented
Jul 20, 2025
| oneof result { | ||
| ListDirectorySuccessResponse success = 1; | ||
| WorkerError error = 2; | ||
| ListFileSystemNodeResponse success = 1; |
There was a problem hiding this comment.
I have left this flatten, repeated FileSystemNode. This is for service, user facing, worker executor has seperated File and Directory. By this time, the structure is already converted into vec, and this is passed to both http endpoint and grpc service. Trying to pass whole structure with both File() and Directory(), requires unnecessary code in both http endpoint and
service, as executor grpc needs to be converted into service grpc.
forwarding.rs -> flattens the values
mschuwalow
approved these changes
Jul 23, 2025
auto-merge was automatically disabled
July 23, 2025 10:23
Head branch was pushed to by a user without write access
|
Test pass locally, tested it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/closes #1761
Changes
for function list_directory -> Rather than outputing NotaDirectory Error, this now Display File(FileSystemNode)
If file is requested at the endpoint, it displays the the meta details of the file rather than displaying Bad file error
This is not the most needed change, especially with new CLI command making it easier to browse files.
I did this first and then the Cli, so. Good to learn atleast.
I update the integration test to test file node as well.
The Cli changes are independent, and will work without this.