Skip to content

Type names #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 22, 2025
Merged

Type names #1853

merged 11 commits into from
Jul 22, 2025

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Jul 21, 2025 •
edited
Loading

Includes:

  • Adds an optional name tag to all types representing WIT types
  • Removes the TypeAnnotatedValue variant completely
  • Removes the old, non-wit-parser based component analysis code
  • Both the IntoValue derive macro and the wit-parser based component analysis fills the name tags

Part of #1828
Resolves #1733

Requires golemcloud/golem-wit#67

@vigoo vigoo merged commit 10e454a into main Jul 22, 2025
39 of 45 checks passed
@vigoo vigoo deleted the type-names branch July 22, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noise64 noise64 noise64 approved these changes

@afsalthaj afsalthaj afsalthaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of TypeAnnotatedValue from every layer
3 participants
@vigoo @noise64 @afsalthaj