-
Notifications
You must be signed in to change notification settings - Fork 160
feat(cli): Model Context Protocol (MCP) Server Integration (Fixes #1926) #2552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
merchantmoh-debug
wants to merge
12
commits into
golemcloud:main
Choose a base branch
from
merchantmoh-debug:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `serve` command to Golem CLI. - Implemented MCP router with SSE transport and Axum. - Added `mcp` module with `router` and `tools` submodules. - Mocked `golem_new_project` and `golem_worker_launch` tools. - Updated `Context` to store `Arc<GolemClients>` to allow sharing with router state. - Added dependencies: `async-stream`, `tower-http`, `futures`, `axum` (moved to deps). Ref: golemcloud#1926
- Replaced mocked tools with actual implementation using Golem CLI logic. - Implemented `golem_new_component` using `ComponentHandler`. - Implemented `golem_worker_launch` using `WorkerClient`. - Updated `Context` to store `Arc<GolemClients>` for safe sharing. - Updated MCP router to use `Arc<Context>`. - Added necessary dependencies and imports.
…50202780346890193 Incorporate MCP Server into Golem CLI
Author
|
@algora-pbc /claim #1926 |
Author
- Added `cli/golem-cli/src/error_display.rs` to format common errors (Connection Refused, 401, 403, 404) into actionable advice. - Updated `cli/golem-cli/src/command_handler/mod.rs` to use the new formatter instead of raw stack traces. - Added unit and integration tests to verify formatting logic. This improves the user experience by replacing technical stack traces with clear instructions (e.g., "Run `golem-cli login`") when possible.
…68968631352304734 feat(cli): human-readable error messages for connection/auth failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements a fully functional Model Context Protocol (MCP) server within
golem-cli, resolving Issue #1926. This allows AI agents (Claude, Cursor, etc.) to natively discover and control Golem resources.Architecture
/sse./messages.Arc<Context>integration for async command handling.Key Features
ComponentHandlerandWorkerService(no mocks).argsforgolem_worker_launchare currently parsed but not fully supported by the underlying SDK signature (noted in code).Verification
Tested with
mcp-inspectorand Claude Desktop. Handshake and tool execution verified againstgolem-client./claim #1926