Skip to content

zephyr: add option to display Golioth Firmware SDK version at boot #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

szczys
Copy link
Contributor

@szczys szczys commented Dec 18, 2024

Use CONFIG_GOLIOTH_SHOW_VERSION_BOOT_MSG symbol (enabled by default) to disable. GOLIOTH_VERSION_INCLUDE_COMMIT (enabled by default) allows the commit hash to be removed from the version number.

image

image

image

Copy link

github-actions bot commented Dec 18, 2024

Visit the preview URL for this PR (updated for commit 290e448):

https://golioth-firmware-sdk-doxygen-dev--pr710-szczys-version-xfsanb79.web.app

(expires Tue, 14 Jan 2025 19:34:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9993e61697a3983f3479e468bcb0b616f9a0578

@szczys szczys force-pushed the szczys/version-during-zephyr-boot branch from d6b853d to fb36763 Compare December 18, 2024 15:00
@szczys szczys self-assigned this Dec 19, 2024
@szczys szczys requested a review from mniestroj January 2, 2025 18:45
Use CONFIG_GOLIOTH_SHOW_VERSION_BOOT_MSG symbol (enabled by default) to
disable. GOLIOTH_VERSION_INCLUDE_COMMIT (enabled by default) allows the
commit hash to be removed from the version number.

Signed-off-by: Mike Szczys <[email protected]>
@szczys szczys force-pushed the szczys/version-during-zephyr-boot branch from fb36763 to 290e448 Compare January 7, 2025 19:32
Copy link

github-actions bot commented Jan 8, 2025

Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
include.golioth 75% 50%
port.linux 62% 34%
port.utils 58% 46%
port.zephyr 58% 25%
src 70% 31%
Summary 69% (2716 / 3943) 31% (1124 / 3621)

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
port/zephyr/golioth_version_boot_msg.c 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@szczys szczys merged commit 9335299 into main Jan 8, 2025
132 of 137 checks passed
@szczys szczys deleted the szczys/version-during-zephyr-boot branch January 8, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants