Skip to content

workflows: standardize titles and filenames #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

szczys
Copy link
Contributor

@szczys szczys commented Dec 31, 2024

Rename and retitle all tests for better organization. This delivers a more uniform list on the GitHub Actions page, and groups workflow files by functionality.

  • Use categories as prefix: ci, doc, hil, report, test, trigger
  • Normalize on '-' instead of '_' in filenames
  • Replace 'test' in filenames with 'integration' to differentiate from 'sample'

Copy link

github-actions bot commented Dec 31, 2024

Visit the preview URL for this PR (updated for commit dcc9a60):

https://golioth-firmware-sdk-doxygen-dev--pr716-szczys-organiz-xqgd3pot.web.app

(expires Thu, 09 Jan 2025 19:52:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9993e61697a3983f3479e468bcb0b616f9a0578

@szczys szczys force-pushed the szczys/run-regular-integration-tests branch from 68029d1 to e90056a Compare December 31, 2024 18:49
@szczys szczys force-pushed the szczys/organize_workflows branch from 41a4006 to 14257e0 Compare December 31, 2024 18:49
Copy link

Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
include.golioth 75% 50%
port.linux 62% 34%
port.utils 58% 46%
port.zephyr 58% 25%
src 70% 31%
Summary 69% (2713 / 3940) 31% (1124 / 3621)

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Contributor

@sam-golioth sam-golioth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking the initiative here @szczys! When this merges, we're probably going to need to update the required checks in the branch protection settings to match the new names.

@szczys szczys force-pushed the szczys/run-regular-integration-tests branch from e90056a to d4745fa Compare January 2, 2025 17:55
Rename and retitle all tests for better organization. This delivers a more
uniform list on the GitHub Actions page, and groups workflow files by
functionality.

- Use categories as prefix: ci, doc, hil, report, test, trigger
- Normalize on '-' instead of '_' in filenames
- Replace 'test' in filenames with 'integration' to differentiate from
  'sample'

Signed-off-by: Mike Szczys <[email protected]>
@szczys szczys force-pushed the szczys/organize_workflows branch from 14257e0 to dcc9a60 Compare January 2, 2025 19:51
@szczys szczys merged commit 0e48ca7 into szczys/run-regular-integration-tests Jan 2, 2025
128 of 133 checks passed
@szczys szczys deleted the szczys/organize_workflows branch January 2, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants