ci: zephyr_integration: avoid collision in test report artifacts #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the report summary, we were downloading the test results for all boards, instead of just the one we're testing. This caused results to be recorded multiple times, and for boards which completed testing later to include results from boards which completed testing earlier. Signed-off-by: Sam Friedman <[email protected]>
|
Visit the preview URL for this PR (updated for commit aefeac8): https://golioth-firmware-sdk-doxygen-dev--pr721-fix-test-repor-wqskx6li.web.app (expires Fri, 10 Jan 2025 22:35:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
mniestroj
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the report summary, we were downloading the test results for all boards, instead of just the one we're testing. This caused results to be recorded multiple times, and for boards which completed testing later to include results from boards which completed testing earlier.
In this screenshot you can see how the ESP32 Zephyr integration test includes results for many more runs than it should:
