workflows: update ModusToolbox to v3.3 #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade build test from ModusToolbox 2.4 to 3.3 to resolve upstream change that prevented `make getlibs` from downloading libraries. Signed-off-by: Mike Szczys <[email protected]>
|
Visit the preview URL for this PR (updated for commit f783d72): https://golioth-firmware-sdk-doxygen-dev--pr722-szczys-modusto-znxpimzb.web.app (expires Mon, 13 Jan 2025 22:59:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
After updating CI to use ModusToolbox 3.3, the build is now successful using Ubuntu 24.04. Signed-off-by: Mike Szczys <[email protected]>
Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
sam-golioth
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Good work tracking this down @szczys! I especially like that we're using secrets for the download ID now.
| libxcb-keysyms1 \ | ||
| libxcb-render-util0 \ | ||
| libxkbcommon-x11-0 \ | ||
| libopengl0 \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade build test from ModusToolbox 2.4 to 3.3 to resolve upstream change that prevented
make getlibsfrom downloading libraries.This workflow is now compatible with
ubuntu-24.04.Resolves https://github.com/golioth/firmware-issue-tracker/issues/759