Update ESP-IDF to v5.4 #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESP-IDF v5.4 change the formate for log color defines. Add ifndef statements to golioth_sys.h to avoid redefinition. Signed-off-by: Mike Szczys <[email protected]>
|
Visit the preview URL for this PR (updated for commit 9a4b01c): https://golioth-firmware-sdk-doxygen-dev--pr724-szczys-bump-es-rw47zdan.web.app (expires Thu, 16 Jan 2025 17:03:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
sam-golioth
approved these changes
Jan 9, 2025
| @@ -40,9 +40,12 @@ struct in6_pktinfo { | |||
| struct in6_addr ipi6_addr; /* src/dst IPv6 address */ | |||
| unsigned int ipi6_ifindex; /* send/recv interface index */ | |||
| }; | |||
|
|
|||
| #ifndef IN6_IS_ADDR_V4MAPPED | |||
There was a problem hiding this comment.
I appreciate the explanation in the commit message! I was going to ask why we didn't just remove it. But it looks like you the last bit of the message is missing.
With ESP-IDF v5.4, LWIP was upgraded to v2.2.0. This includes a new IN6_IS_ADDR_V4MAPPED(a) macro that is defined in lwip/inet.h. It conflicts with the macro in Golioth's copy of the ESP-IDF port's coap_config_posix.h. The macro is still present in ESP-IDF's coap_config_posix.h, so instead of removal, the macro in Golioth's coap_config_posix.h is guarded with ifndef. Signed-off-by: Mike Szczys <[email protected]>
Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/bump-espidf-5.4
branch
from
1ddd2cf to
9a4b01c
Compare
Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK Changes Due to this Update:
idf.py monitornow handles colorization.Resolves https://github.com/golioth/firmware-issue-tracker/issues/734