fw_update: make rollback timer period configurable #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces CONFIG_GOLIOTH_FW_UPDATE_ROLLBACK_TIMER_S to control the rollback period. Also changes the default to 300 seconds, from the previously hardcoded 60 seconds. Signed-off-by: Sam Friedman <[email protected]>
|
Visit the preview URL for this PR (updated for commit c686cbb): https://golioth-firmware-sdk-doxygen-dev--pr738-make-rollback-y1y4mpo7.web.app (expires Wed, 05 Feb 2025 17:52:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
MarkoPura
approved these changes
Jan 29, 2025
hasheddan
approved these changes
Jan 29, 2025
sam-golioth
force-pushed
the
make_rollback_time_configurable
branch
from
63439b4 to
c686cbb
Compare
Code Coverage
|
Codecov ReportAttention: Patch coverage is
|
mniestroj
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces CONFIG_GOLIOTH_FW_UPDATE_ROLLBACK_TIMER_S to control the rollback period. Also changes the default to 300 seconds, from the previously hardcoded 60 seconds.