coap_blockwise: test for null before dereferencing pointer #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9a87bfc): https://golioth-firmware-sdk-doxygen-dev--pr761-szczys-blockwi-0c2sg5yf.web.app (expires Fri, 18 Apr 2025 14:58:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
szczys
force-pushed
the
szczys/blockwise-test-null-ctx
branch
from
fc3301d to
bf79b33
Compare
Code Coverage
|
Codecov ReportAttention: Patch coverage is
|
trond-snekvik
approved these changes
Apr 10, 2025
sam-golioth
approved these changes
Apr 10, 2025
The `path` member of the blockwise_transfer context is freed when the "finish" function is called. Test the context for NULL before trying to free the member. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/blockwise-test-null-ctx
branch
from
bf79b33 to
9a87bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pathmember of the blockwise_transfer context is freed when the "finish" function is called. Test the context for NULL before trying to free the member.