CI: use polling when fetching logs #879
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poll until fetched log count matches the expected number of entries. Polling includes a timeout and will assert. Signed-off-by: Mike Szczys <[email protected]>
poll until fetched log count matches the expected number of entries. Polling includes a timeout and will assert. Signed-off-by: Mike Szczys <[email protected]>
|
Visit the preview URL for this PR (updated for commit e2e2497): https://golioth-firmware-sdk-doxygen-dev--pr879-szczys-ci-use-3nufyrbh.web.app (expires Fri, 26 Dec 2025 21:54:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Code Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. |
szczys
force-pushed
the
szczys/ci-use-polling-for-logs
branch
from
0bff22e to
71fa9d6
Compare
poll until fetched log count matches the expected number of entries. Polling includes a timeout and will assert. Signed-off-by: Mike Szczys <[email protected]>
poll until fetched log count matches the expected number of entries. Polling includes a timeout and will assert. Signed-off-by: Mike Szczys <[email protected]>
- Use `is not` instead of `!=` when comparing to None - Use `except Exception:` in place of `except:` This commit does not not alter any functionality of the test. Signed-off-by: Mike Szczys <[email protected]>
poll until fetched log count matches the expected number of entries. Polling includes a timeout and will assert. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/ci-use-polling-for-logs
branch
from
71fa9d6 to
e2e2497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sample and integration tests that query logs, use polling to account for the async nature of the logging system.