transport: ble_gatt: support selection between LESC / AUTHEN #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-golioth
approved these changes
Dec 16, 2025
Collaborator
sam-golioth
left a comment
sam-golioth
left a comment
There was a problem hiding this comment.
Thanks @mniestroj! 2 non-blocking comments
| help | ||
| Directory on mounted file system containing credentials. | ||
|
|
||
| config EXAMPLE_BT_AUTO_CONFIRM |
Collaborator
There was a problem hiding this comment.
Can we add a comment that says that this symbol is only for automated testing? So users don't get confused when reading this file.
examples/ble_gatt/src/main.c
Outdated
| } | ||
| else | ||
| { | ||
| LOG_INF("No BT connection for passkey confirmation"); |
Collaborator
There was a problem hiding this comment.
Suggested change
| LOG_INF("No BT connection for passkey confirmation"); | |
| LOG_WRN("No BT connection for passkey confirmation"); |
Add BT auth callbacks, which are required to display passkey to the user (over serial console). Confirmation is handled by pressing button (/aliases/sw0 in devicetree). Add also EXAMPLE_BT_AUTO_CONFIRM option for handling auto-confirmation for nrf52_bsim board. There is no easy to use "manual" confirmation method for this platform, so confirming automatically is the easiest way to go. This makes sense especially for automated tests with pouch-gateway, as that will result in working BT communication without any additional external Pytest code. Signed-off-by: Marcin Niestroj <[email protected]>
Introduce Kconfig option for required GATT permissions. Provide 2 options: * LE Secure Connection * Authentication (with encryption) This makes sure that proper BT Security Level is reached before trying being able to access pouch characteristics. Signed-off-by: Marcin Niestroj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Kconfig option for required GATT permissions. Provide 2 options:
This makes sure that proper BT Security Level is reached before trying being able to access pouch characteristics.
Add BT auth callbacks to example code, which are required to display passkey to the user (over serial console). Confirmation is handled by pressing button (/aliases/sw0 in devicetree).
Add also EXAMPLE_BT_AUTO_CONFIRM option for handling auto-confirmation for nrf52_bsim board. There is no easy to use "manual" confirmation method for this platform, so confirming automatically is the easiest way to go. This makes sense especially for automated tests with pouch-gateway, as that will result in working BT communication without any additional external Pytest code.