This repository was archived by the owner on Dec 30, 2021. It is now read-only.
Add CI job #1
Merged
Add CI job #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalezreal
force-pushed
the
ci
branch
2 times, most recently
from
f05254f to
e628372
Compare
gonzalezreal
commented
Sep 23, 2020
| default: test | ||
|
|
||
| test: | ||
| xcodebuild test \ |
Owner
Author
There was a problem hiding this comment.
We should add a command to run the tests on macOS once macOS 11.0 is officially released, together with Xcode 12.2.
gonzalezreal
commented
Sep 23, 2020
| let view = AdaptiveCardView(url: fixtureURL("richTextBlock.json")) | ||
| .animation(nil) | ||
| .adaptiveCardConfiguration(HostConfig()) | ||
| .environment(\.locale, Locale(identifier: "en_US")) |
Owner
Author
There was a problem hiding this comment.
This test was flaky when using the date and time formatting, even forcing the language and locale in xcodebuild. I removed the date formatting part from the fixture.
gonzalezreal
commented
Sep 23, 2020
| assertSnapshot(matching: vc, as: .wait(for: 0.25, on: .image)) | ||
| } | ||
|
|
||
| func testDateAndTime() { |
Owner
Author
There was a problem hiding this comment.
Another flaky test that was failing when running CI, even specifying language and locale in xcodebuild.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI job and fix watchOS build