Add Relation class and .relation_map() methods #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Senses and Synsets now have an `incoming_relation()` method. The value of this method returns a SenseRelation, SenseSynsetRelation, or SynsetRelation object if the Sense/Synset is the result of a relation traversal. Otherwise the method returns `None`. The new relation objects specify the relation name, the source and target IDs of the relation, and the lexicon where the relation originated. Fixes #216 Fixes #167
The .relation_map() method is like .relations(), but the keys are relation objects and map 1-to-1 to targets. This commit also removes the .source() and .target() methods as they didn't work in common situations, as well as the .incoming_relation() method as it was not favored. This commit also adds a new utility function and associated unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Relation class for modeling sense and synset relations so the source lexicon, metadata, etc. of the relations are accessible. This allows for two main use cases:
otherrelationsResolves #167
Resolves #216