Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct UI state for Gemma models #537

Closed
wants to merge 1 commit into from

Conversation

iurysza
Copy link

@iurysza iurysza commented Mar 17, 2025

Description

Fixes an issue where incorrect UI state was being used for Gemma models, which caused it to use the wrong turn markers to structure the conversation.

Checklist

  • My code follows the code style of the project.
  • I have updated the documentation (not applicable).
  • I have added tests to cover my changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update (non-breaking change which updates documentation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@schmidt-sebastian
Copy link
Collaborator

The Gemma3 task file has the prompt format encoded via it's internal configuration. Thus, the turn markers no longer need to be send from the app. Let us know if this is not working for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants