Pub/Sub streaming pull requests #58
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements endpoints for the Pub/Sub bi-directional stream, with a few limitations at the moment:
futures::stream::unfoldwhich does not leave room for proper error handling (the stream can send error messages, always terminating the connection AFAIK), and changing the item type to be Result seems a bit overkill to me. But right now, the stream can fail silently, abruptly finishing the stream.I had to update the protobuf definitions as well, and I moved to a submodule instead to easily keep them up to date here. I'll revert if that's unwanted.
I needed this feature as part of a high-throughput system, and as such this PR is being battle-tested right now! 😄
closes #57