Missing MaxPool2d #815
Open
Missing MaxPool2d #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a MinPool and MaxPool layer inside the pool.py file under the src folder. Then I added a file named maxpooluse.py in the examples directory to show how it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, I'm Debaditya Adas, currently exploring Haiku and JAX. I'm a beginner in frameworks and a Python module designer. I found this issue interesting, though I’m still quite new in this field and still learning.
So, I’ve tried to create a MinPool and MaxPool layer inside the pool.py file under the src folder. Then I added a file named maxpooluse.py in the examples directory to show how it works.
I’ve done some research and also took a bit of help from ChatGPT to understand the structure. The code is written by me. Although I'm not completely confident since I’m still learning.
If it's helpful, could you please review it and let me know if it’s really good or not? I’m still a little bit confused.