Introduce an IndexedHashMap, which has constant time lookup and stable iteration order.
#864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…ble iteration order. This change introduces an `IndexedHashMap`, which has O(1) lookup but stable iteration order. Under the hood, this is just a combination of a `absl::flat_hash_map` from key to index and a `std::vector` containing the values. This can't really use a standard C++ interface due to the key and the value not being co-located, but we can provide a sensible alternative map interface for it. PiperOrigin-RevId: 501124236
copybara-service
bot
force-pushed
the
test_501124236
branch
from
905a7b1
to
2c0a38f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an
IndexedHashMap, which has constant time lookup and stable iteration order.This change introduces an
IndexedHashMap, which has O(1) lookup but stable iteration order. Under the hood, this is just a combination of aabsl::flat_hash_mapfrom key to index and astd::vectorcontaining the values. This can't really use a standard C++ interface due to the key and the value not being co-located, but we can provide a sensible alternative map interface for it.