Skip to content

Rename best_fn to get_metric_fn in CheckpointManagerOptions. #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Rename best_fn to get_metric_fn in CheckpointManagerOptions. #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion t5x/checkpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2285,7 +2285,7 @@ def best_fn(metrics):
max_to_keep=keep,
save_interval_steps=period,
keep_period=force_keep_period,
best_fn=best_fn if metric_name_to_monitor is not None else None,
get_metric_fn=best_fn if metric_name_to_monitor is not None else None,
best_mode=metric_mode,
keep_checkpoints_without_metrics=keep_checkpoints_without_metrics,
cleanup_tmp_directories=True,
Expand Down
6 changes: 3 additions & 3 deletions t5x/utils_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,10 +742,10 @@ def test_create_orbax_checkpoint_manager(
expected_keep_checkpoints_without_metrics,
)
if expected_metric is None:
self.assertIsNone(manager._manager._options.best_fn)
self.assertIsNone(manager._manager._options.get_metric_fn)
else:
self.assertEqual(
manager._manager._options.best_fn(metrics),
manager._manager._options.get_metric_fn(metrics),
expected_metric,
)

Expand Down Expand Up @@ -812,7 +812,7 @@ def test_create_orbax_checkpoint_manager_from_checkpointer(
self.assertEqual(manager._manager._options.best_mode, "max")
self.assertTrue(manager._manager._options.keep_checkpoints_without_metrics)
self.assertEqual(
manager._manager._options.best_fn(
manager._manager._options.get_metric_fn(
{"train/accuracy": 0.8, "train/loss": 0.1}
),
0.8,
Expand Down
Loading