Changes related to #13: Adds focal, fov #24
Conversation
Achint08
commented
May 30, 2022
•
Achint08
commented
- Adds properties related to:
- Focus
- Field of view.
- Adds tests related to changes.
|
@Conchylicultor Please review! |
Achint08
force-pushed
the
changes_for_focal_fov
branch
from
7168e15
to
fb9909b
Compare
| def fov(self) -> float: | ||
| """Field of view in radians (`(fov_w, fov_h)`).""" | ||
|
|
||
| return (self.fov_w, self.fov_h) |
There was a problem hiding this comment.
I would rename fov -> fov_hw (as .fov sounds like it should be a single value)
| return (self.w, self.h) | ||
|
|
||
| @property | ||
| def fw(self) -> float: |
There was a problem hiding this comment.
I don't think users will often need this property and this can easily be extracted with cam.focal_px_wh[0]. Which is more explicit than fw (e.g. as focal is sometimes defined in mm).
So I would remove those fw, fh
| f'different: {self.focal_px_wh}' | ||
| ) | ||
|
|
||
| if self.fw != self.fh: |
There was a problem hiding this comment.
focal is focal, so we should use isclose
| return (self.w, self.h) | ||
|
|
||
| @property | ||
| def fw(self) -> float: |
There was a problem hiding this comment.
Contrary to the resolution which is always constant across all camera stacked together, focal length can vary for individual cameras.
This means we should wrap the property around @vectorize_method similarly to the scale property in
visu3d/visu3d/dc_arrays/transformation.py
Line 224 in 11c8f97
This would allow for example to vary the focal length across camera, like:
cams = v3d.PinholeCamera(
resolution=(h, w),
focal_in_px=[200, 240, 260, 300],
)
cams.shape == (4,) # 4 cameras stacked together with focal 200, 240,...This also mean focal_length should likely be a FloatArray['*shape 2']
| return self.focal_length[1] | ||
|
|
||
| @property | ||
| def focal_px_wh(self) -> tuple[float, float]: |
There was a problem hiding this comment.
This seems redundant with focal_length defined line 110.
To keep the API minimal, I would remove this property and rename focal_length -> focal_px_wh in the dataclass attribute.
