Skip to content

Conversation

@langmore
Copy link
Contributor

  • setup.py: Changed dependences by moving some deps into base_requires
  • scripts/slice_dataset.py: Added MAX_MEM because GCP users want to save money and use a smaller instance. Added _assert_nonzero_slices to catch a common user misspecification.
  • scripts/compute_probabilistic_climatological_forecasts.py: Added MAX_MEM as above. Moved some FLAGS out of lambdas, so their value can be found on workers.
  • Tests pass
  • [Nope] Appropriate changes to documentation are included in the PR

Copy link
Collaborator

@raspstephan raspstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@raspstephan
Copy link
Collaborator

There are some errors in the tests, maybe you can take a look.

@langmore
Copy link
Contributor Author

I updated setup.py, preventing the latest xarray. See similar WBX PR.

I also tweaked the deps for beam, added to .gitignore, and re-tested. Let's hope the pipeline passes this time.

@langmore
Copy link
Contributor Author

@raspstephan Things should be good now. The errors were associated with the xarray update (recall I fixed that for WBX, and used the same change here). I can't run the pipeline though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants