Skip to content

Add async and await support to DaysUntilBirthday Swift sample app #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add async and await support to DaysUntilBirthday Swift sample app #191

wants to merge 14 commits into from

Conversation

mdmathias
Copy link
Collaborator

No description provided.

@mdmathias mdmathias requested review from petea and Alex-4-Git August 2, 2022 00:21
@petea
Copy link
Contributor

petea commented Aug 2, 2022

Could you rebase this branch against main to exclude the already-merged API refactoring changes here?

@mdmathias mdmathias force-pushed the mdmathias/async-support branch from c485819 to b82ac43 Compare August 2, 2022 19:25
@mdmathias
Copy link
Collaborator Author

Yep! Sorry about that.

petea
petea suggested changes Aug 3, 2022
View reviewed changes
@mdmathias mdmathias force-pushed the mdmathias/async-support branch from b82ac43 to 0bb46ee Compare August 3, 2022 23:28
This was referenced Aug 5, 2022
Closed
Closed
@mdmathias mdmathias force-pushed the mdmathias/async-support branch from 0bb46ee to db1677e Compare August 5, 2022 21:45
petea
petea approved these changes Aug 6, 2022
View reviewed changes
Copy link
Contributor

@petea petea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Discussed offline and agreed that we would wait to merge into main until we're closer to shipping Swift Concurrency support.

@petea petea added this to the 7.0.0 milestone Nov 2, 2022
@petea petea force-pushed the mdmathias/async-support branch from 14368a9 to a75b5ab Compare December 8, 2022 22:59
@petea
Copy link
Contributor

petea commented Dec 9, 2022 •
edited
Loading

@mdmathias this is now in sync with main and works as expected locally for me (including integration tests) but something seems to have broken integration tests on GitHub. I'm wondering if it's Xcode 14 related as I'm still using 13 locally.

@petea petea force-pushed the mdmathias/async-support branch from 36fb2dd to d0deb73 Compare December 9, 2022 19:06
@petea petea removed this from the 7.0.0 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petea petea petea approved these changes

@Alex-4-Git Alex-4-Git Alex-4-Git approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdmathias @petea @Alex-4-Git