crio: only collect required metrics for infra container#3592
Closed
haircommander wants to merge 1 commit intogoogle:masterfrom
Closed
crio: only collect required metrics for infra container#3592haircommander wants to merge 1 commit intogoogle:masterfrom
haircommander wants to merge 1 commit intogoogle:masterfrom
Conversation
as we'll only use the network metrics from it Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
network-metrics-optimization
branch
from
100eaa3 to
39f93dc
Compare
kolyshkin
reviewed
Sep 12, 2024
Contributor
Author
bitoku
reviewed
Sep 23, 2024
| // as the rest will be discarded. | ||
| if cInfo.Labels["io.kubernetes.container.name"] == "POD" { | ||
| // Only include the non-non-network metrics. This way, we can tell if there are no network metrics | ||
| metrics = includedMetrics.Difference(nonNetworkMetrics) |
There was a problem hiding this comment.
Would adding something like Intersect function in MetricsSet make more sense?
Collaborator
|
/ok-to-test |
Contributor
Author
|
I'm not actually positive this helps |
iwankgb
approved these changes
Oct 5, 2024
iwankgb
requested changes
Oct 5, 2024
Collaborator
iwankgb
left a comment
iwankgb
left a comment
There was a problem hiding this comment.
Blocking per @haircommander's comment.
Contributor
Author
|
come to think of it, this will improve some, but it won't materially improve, we can keep or drop this, I think it techincally will save a bit of time but not really enough to notice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as we'll only use the network metrics from it