Skip to content

Conversation

@gfrey
Copy link

@gfrey gfrey commented Nov 24, 2025

Allows to merge two maps. Maps must have identical value types. Keys of the second map take precedence.

I initially wrote this library for kro (see kubernetes-sigs/kro#628), but was asked to contribute it here.

Pull Requests Guidelines

See CONTRIBUTING.md for more details about when to create
a GitHub Pull Request and when other kinds of contributions or
consultation might be more desirable.

When creating a new pull request, please fork the repo and work within a
development branch.

Commit Messages

  • Most changes should be accompanied by tests.
  • Commit messages should explain why the changes were made.
Summary of change in 50 characters or less

Background on why the change is being made with additional detail on
consequences of the changes elsewhere in the code or to the general
functionality of the library. Multiple paragraphs may be used, but
please keep lines to 72 characters or less.

Reviews

  • Perform a self-review.
  • Make sure the Travis CI build passes.
  • Assign a reviewer once both the above have been completed.

Merging

  • If a CEL maintaner approves the change, it may be merged by the author if
    they have write access. Otherwise, the change will be merged by a maintainer.
  • Multiple commits should be squashed before merging.
  • Please append the line closes #<issue-num>: description in the merge message,
    if applicable.

Allows to merge two maps. Maps must have identical value types. Keys of
the second map take precedence.
@TristonianJones
Copy link
Collaborator

/gcbrun

@a-hilaly
Copy link

a-hilaly commented Dec 8, 2025

Hey @TristonianJones - this PR was originally opened against kubernetes-sigs/kro code base and we advised to contribute to upstream cel-go instead. Do you think this is something you're interested in taking? :)

@TristonianJones
Copy link
Collaborator

@a-hilaly thanks for the referral. I think we just need to consider how best to make this approach work for a variety of types and a variety of merge heuristics. Definitely interested though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants