Use "key" instead of "value" in HashMap exercise

[PaulXiCao]

No description provided.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[djmitche]

What motivates this change? The objective is to count values, so it seems like 'value' is a good name.

It uses a std::collections::HashMap to keep track of which values have been seen and how many times each one has appeared.

[PaulXiCao]

It is just that key/value have usually predefined meanings for hashmaps (associative containers in general). And as this is an exercise to for the API of hashmaps it might put some people off that the variable 'value' is used as a key.

Unsure if the proposed renaming is the best though. What about "values -> itemOccurences" and "value -> item"?

(Sorry about the formatting. I am on my phone atm.)

[djmitche]

I think a PR to change both the word used in the exercise and the variable name would be OK. itemOccurrences sounds pretty long, but item and items is probably OK!

[PaulXiCao]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

I dont have a gmail account.

[djmitche]

The error log shows an obscured Gmail address. I don't know the details of the cla process - is there no alternative?

…

On Sun, Jun 29, 2025, 8:55 AM PaulXiCao ***@***.***> wrote: *PaulXiCao* left a comment (google/comprehensive-rust#2763) <#2763 (comment)> Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation <https://github.com/google/comprehensive-rust/pull/2763/checks?check_run_id=43317406936> of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. I dont have a gmail account. — Reply to this email directly, view it on GitHub <#2763 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAHAAKJNK4DB6WUOOC34VL3F7O5PAVCNFSM6AAAAAB6NJVZQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMJWGY3TGMRRGM> . You are receiving this because you commented.Message ID: ***@***.***>

[djmitche]

From the FAQ:

Can I sign the Google CLA without a Google account?

A Google account is required to sign the CLA. Google accounts are used to link individual and corporate CLAs to covered contributors and provide authentication for CLA management.