Skip to content

Conversation

@juergw
Copy link
Collaborator

@juergw juergw commented Nov 20, 2025

ScopedByteArrayRO may need to allocate memory, and that allocation may fail. When this happens, which should throw an error.

We also add a check before that if the input is null, and throw an exception in that case. This preserves the current behavior. Without that, an out of memory exception would be thrown if the input is null, which is not what we want.

@juergw
Copy link
Collaborator Author

juergw commented Nov 20, 2025

I also remove some logging of private keys.

@prbprbprb
Copy link
Contributor

I also remove some logging of private keys.

Note that JNI_TRACE compiles to nothing unless conscrypt::trace::kWithJniTrace is true at compile time, so there should be no accidental leakage of keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants