Avoid misaligned pointer access on AArch64 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `data` type is a pointer to `uint8_t`, accessing memory via a pointer of a larger type, such as `(uint64_t*)data`, results in misalignment. This can be problematic on ARM hardware. Specifically: 1. It triggers "misaligned-pointer-use" UBSan warnings. 2. It triggers "-Wcast-align=strict" warnings when compiling with GCC.
|
Oops, I put together #65 before noticing that you'd already done this. I think adding the wrapper functions is a little tidier (avoids the macros depending on some random local variables), but I've no strong preference between the two. I'll try to find someone to merge one of the two, since it seems folks might not be paying attention to this repo these days. |
|
Apologies, I just noticed this now. #65 looks like it covers the same problem, and I'm in contact with the author. Closing in favor of that PR, which is about to get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
datatype is a pointer touint8_t, accessing memory via a pointer of a larger type, such as(uint64_t*)data, results in misalignment. This can be problematic on ARM hardware. Specifically: