Fix a memory performance issue when creating Dagger's BindingGraph. #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_577967631
branch
from
2fdda45 to
3b37c35
Compare
copybara-service
bot
force-pushed
the
test_577967631
branch
from
3b37c35 to
d9d0a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a memory performance issue when creating Dagger's BindingGraph.
This CL fixes an issues where each subcomponent was storing its complete list of accessible bindings, which includes any bindings it needs from its ancestor components. This ends up requiring much more space than actually required if we just store the bindings owned by the subcomponent and delegate to the parent component for any bindings accessible there.
I think this can likely be done for our
LegacyBindingGraphclasses as well, but I'll save that for another CL.RELNOTES=N/A