Check branch exists when editing a task #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-hertz
previously approved these changes
Jan 30, 2018
|
Don't merge pull request for now please. |
jillemash
dismissed
sebastien-hertz’s stale review
There's more check to be made before merging this. I already see some issues with this approach.
|
This does not work as it requires a repo to have been previously cloned, which is not yet the case before any task has been executed.
|
added 4 commits
January 31, 2018 15:55
This way, checks on task form entries concerning branch or commit id can work.
Also make clone() return output of command, so error can be checked by caller.
dana-bot/src/www.js
Outdated
| appError(req, res, '/bot/' + serviceName + ', repository of ' + repoName + ' could not be cloned'); | ||
| return; | ||
| } | ||
| var fetchOut = gitForBot.fetch(); |
There was a problem hiding this comment.
IMO the fetch part should be in the else clause of the if. I mean you only need to 'git fetch' if the repo already exists (and you want to update remote info), otherwise you'd do the 'git clone' which would give an up-to-date repo.
There was a problem hiding this comment.
I agree, although the fetch part should take no time if the repo just got cloned, it makes more sense that way. Done in upcoming commit.
sebastien-hertz
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30