Ignore StateError when closing sockets, and attempt multiple times. #270
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
approved these changes
Mar 26, 2025
sigurdm
reviewed
Mar 27, 2025
Comment on lines
+244
to
+246
| // NOTE: Sadly, this can throw, it can even throw synchroniously, | ||
| // implying [Socket] from 'dart:io' fails to implement | ||
| // [StreamSink] as specified. |
There was a problem hiding this comment.
Suggested change
| // NOTE: Sadly, this can throw, it can even throw synchroniously, | |
| // implying [Socket] from 'dart:io' fails to implement | |
| // [StreamSink] as specified. | |
| // NOTE: Sadly, this can throw, it can even throw synchroniously, | |
| // implying [Socket] from 'dart:io' fails to implement | |
| // [StreamSink] as specified. |
If this is true we should add a issue number here.
sigurdm
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
If we feel we need this band-aid I don't mind approving it - but it gives me the heebie-jeebies.
I don't like catch-alls if they can be avoided. They can cover up other issues
I despise having to catch StateErrors. It implies we are holding it wrong.
I think we have the responsibility to file tracking issues for sdk bugs.
Maybe we need a wrapper of the StreamSink that ignores adds after a close(), if we want a kill-switch for our stream. Or we keep track of all on-going addStream futures, and await them before closing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will fix issues where the connections are not closed correctly.