Added display of PM4 packets for passes (e.g. resolve, binning, etc) #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 29, 2024 08:19
# Conflicts: # dive_core/command_hierarchy.cpp
Shared packets for IB nodes are done via the SetStartSharedChildrenNodeIndex & SetEndSharedChildrenNodeIndex mechanism
… the entire packet Also includes a rename of variables to take into account passes being selected, and not just events
wangra-google
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes showing all BinPrefix and BinCommon IBs as actual children of the CP_START_BIN packet, as well as dealing with all the highlighting, selecting, and scroll-to issues that come with that:
This also fixes some major bugs with what IBs individual PM4 packets were added to.