Updating build scripts targeting android #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally the Windows gradle build can be triggered from the cmake file too, but I couldn't get that to work (seemed to be an issue with WORKING_DIRECTORY). |
RenfengLiu
reviewed
Jan 15, 2025
RenfengLiu
approved these changes
Jan 15, 2025
GrantComm
pushed a commit
to GrantComm/dive
that referenced
this pull request
Jul 11, 2025
Made changes to build scripts to make the process between Windows and Linux hosts more similar. Also updated documentation. Now in both scripts: * ability to pass a parameter to specify build for only one type (Debug/Release) with basic input validation * gfxr replay files are copied to build_android/<BUILD_TYPE>/third_party/gfxreconstruct/android/tools/replay * start and end time is reported at the end of execution * gradle is passed the flag --console=verbose for more descriptive and permanent output Remaining differences: * where gradle builds for gfxr are triggered * on Windows this is triggered from build_android.bat * on Linux this is triggered from cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to build scripts to make the process between Windows and Linux hosts more similar. Also updated documentation.
Now in both scripts:
build_android/<BUILD_TYPE>/third_party/gfxreconstruct/android/tools/replay--console=verbosefor more descriptive and permanent outputRemaining differences:
build_android.batcmake