Skip to content

Adding initial support for GFXR replay and replaying a GFXR capture #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

angela28chen
Copy link
Collaborator

The intended use case is documented in the README, now users can replay gfxr captures with fewer steps:

  1. Build Dive targeting Windows/Linux to build the dive_client_cli tool
  2. Build Dive targeting Android to trigger the GFXR builds
  3. (Optional) Upload GFXR capture to device
  4. (Optional) Set the environment variable ANDROID_SERIAL if multiple adb devices are connected
  5. Run the gfxr_replay command

Noteworthy changes:

  • Release and Debug builds will both install files into install folder.
  • GFXR replay apk is added to install folder and renamed gfxr-replay.apk.
  • Added returning 0/1 for the main function in dive_client_cli tool.

@angela28chen
Copy link
Collaborator Author

Notes:

  • I don't think the Release version of GFXR replay apk is installing properly, I tried on a clone of GFXR repo at head and it's not working for me there either.
  • Since I'm using the GFXR python script, I avoided using the AndroidDevice when implementing gfxr_replay command.

@angela28chen angela28chen changed the title Adding initial support for GFXR replay and replaying a GFXR capture. Adding initial support for GFXR replay and replaying a GFXR capture Mar 5, 2025
@angela28chen angela28chen enabled auto-merge (squash) March 7, 2025 21:00
@angela28chen angela28chen merged commit cffb55b into google:main Mar 7, 2025
7 checks passed
@angela28chen angela28chen deleted the deploy-gfxr-replay branch March 7, 2025 21:45
GrantComm pushed a commit to GrantComm/dive that referenced this pull request Jul 11, 2025
…oogle#176)

The intended use case is documented in the README, now users can replay gfxr captures with fewer steps:

1. Build Dive targeting Windows/Linux to build the dive_client_cli tool
2. Build Dive targeting Android to trigger the GFXR builds
3. (Optional) Upload GFXR capture to device
4. (Optional) Set the environment variable ANDROID_SERIAL if multiple adb devices are connected
5. Run the gfxr_replay command

Noteworthy changes:

* Release and Debug builds will both install files into install folder.
* GFXR replay apk is added to install folder and renamed gfxr-replay.apk.
* Added returning 0/1 for the main function in dive_client_cli tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants