Skip to content

Build the Dive OpenXR/Vulkan Layer only for Android #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

elviscapiaq
Copy link
Collaborator

@elviscapiaq elviscapiaq commented Mar 7, 2025

  • We have been building the Dive Layer for non-Android platforms like
    Windows, however, we only want this library for Android (device).

@elviscapiaq elviscapiaq changed the title Fix and issue Build the Dive OpenXR/Vulkan Layer only for Android Mar 7, 2025
@elviscapiaq elviscapiaq marked this pull request as ready for review March 7, 2025 22:52
@wangra-google
Copy link
Collaborator

i have mixed feeling on this change. personally i still use vs2022 to build the windows version to make sure no compiling errors in the layer code. it is easier to detect errors in vs2022 in general. @RenfengLiu what do you think?

@RenfengLiu
Copy link
Collaborator

i have mixed feeling on this change. personally i still use vs2022 to build the windows version to make sure no compiling errors in the layer code. it is easier to detect errors in vs2022 in general. @RenfengLiu what do you think?

I'm not sure about the errors, if this is the case, probably we'll need to adjust the cmake flags to show them. Personally, I think this is better as there's fewer maintenance needs to support windows build of the layer, as we dont' really need the layer to run,and the pm4 capture stuff won'd work on windows as well.

@wangra-google
Copy link
Collaborator

i have mixed feeling on this change. personally i still use vs2022 to build the windows version to make sure no compiling errors in the layer code. it is easier to detect errors in vs2022 in general. @RenfengLiu what do you think?

I'm not sure about the errors, if this is the case, probably we'll need to adjust the cmake flags to show them. Personally, I think this is better as there's fewer maintenance needs to support windows build of the layer, as we dont' really need the layer to run,and the pm4 capture stuff won'd work on windows as well.

not only showing them, but also click the error and redirect quickly to the errors.

- We have been building the Dive Layer for non-Android platforms like
  Windows, however, we only want this library for Android (device).
@elviscapiaq elviscapiaq merged commit c1295bc into google:main Mar 11, 2025
9 checks passed
@elviscapiaq elviscapiaq deleted the cmake_issue branch April 26, 2025 15:16
GrantComm pushed a commit to GrantComm/dive that referenced this pull request Jul 11, 2025
- We have been building the Dive Layer for non-Android platforms like
  Windows, however, we only want this library for Android (device).
GrantComm pushed a commit to GrantComm/dive that referenced this pull request Jul 11, 2025
- We have been building the Dive Layer for non-Android platforms like
  Windows, however, we only want this library for Android (device).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants