Expand the set up section of the README #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, CMake and Ninja are required, so tell people to install them. Second, the way that Gradle works requires a few specific call-outs in our setup instructions: 1. Echo Java 17 requiement. Gradle is used to build the Android part of GFXR. Each version of Gradle has a maximum supported version of Java; see: https://docs.gradle.org/current/userguide/compatibility.html. GFXR uses Gradle 8.1 which has a max supported version of Java 19 (to invoke Gradle itself). While technically 18 and 19 are supported, Debian does not provide those versions through the package manager. 2. While Gradle will automatically download the SDK and NDK that it needs for a project, it will only do so if you have accepted the licenses. The easiest way to do this is to install Android Studio get an SDK through the setup process. After accepting the licenses, Gradle will be happy to take care of the rest. Also, Android Studio is essentially the only way to attach a debugger to Android apps.
footballhead
requested review from
elviscapiaq
and removed request for
angela28chen
elviscapiaq
previously approved these changes
May 26, 2025
RenfengLiu
reviewed
May 27, 2025
RenfengLiu
previously approved these changes
May 28, 2025
footballhead
commented
May 28, 2025
RenfengLiu
approved these changes
May 28, 2025
elviscapiaq
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, CMake and Ninja are required, so tell people to install them.
Second, the way that Gradle works requires a few specific call-outs in our setup instructions: