Communication protocol for Dive: Socket connection

[elviscapiaq]

• The socket connection header and its implementation were added.
• An initial cmake setup was added for transfer_client and transfer_server libraries.

[elviscapiaq]

I fixed the issue with Windows when targeting shared libraries for both: client and server. For shared libraries I added the linking with the WIN Sockets.

[elviscapiaq]

I changed the commit title to "Communication protocol for Dive: Socket connection".

[angela28chen]

Have you considered using different files rather than #ifdef _WIN32 for the platform-specific code, with the cmake file dictating the appropriate files to include during the build? My impression is that having it structured like that would be easier to read and maintain, especially since seeing the socket_connection.cc logic here is so different between Linux and Windows.

EDIT: For example, how capture_service/command_utils_win32.cc is set up

[elviscapiaq]

I updated the error handling style to absl::Status and absl::StatusOr. I think now it is more clear the error handling process along the files.

[angela28chen]

LGTM and thanks for switching to using abseil!

I don't know if you saw my earlier comment but I was wondering if there is a reason you are leaning towards using many ifdef statements for the differences between windows/linux VS doing something like implementing separate platform-specific files for implementations of SocketConnection and NetworkInitializer? My impression is that the ifdef approach works but is not generally recommended because it makes code harder to read and you're more likely to run into issues with defines.

[elviscapiaq]

LGTM and thanks for switching to using abseil!

I don't know if you saw my earlier comment but I was wondering if there is a reason you are leaning towards using many ifdef statements for the differences between windows/linux VS doing something like implementing separate platform-specific files for implementations of SocketConnection and NetworkInitializer? My impression is that the ifdef approach works but is not generally recommended because it makes code harder to read and you're more likely to run into issues with defines.

I think I misunderstood your comment; I thought it was about _WIN32 modification. I'll keep your recommendation in mind, and once I finish all the implementation, I can work on that if there are no higher priorities. Thanks!