Communication protocol for Dive: Messages #226
Conversation
elviscapiaq
commented
Jun 4, 2025
elviscapiaq
commented
- Messages (Request/Response) were added for the socket connection.
- Helper functions for messages were added.
|
A general comment: better to follow the Dive naming convention by adding |
Are things like this written down somewhere? |
not as I know. it is used from the Stadia Dive project, so I tend to follow that to keep the code consistent. |
elviscapiaq
force-pushed
the
socket
branch
2 times, most recently
from
0ef9bc7 to
2103bd9
Compare
Updated to this naming convention. |
network/messages.h
Outdated
| HANDSHAKE_RESPONSE = 2, | ||
| PING_MESSAGE = 3, | ||
| PONG_MESSAGE = 4, | ||
| CAPTURE_REQUEST = 5, |
There was a problem hiding this comment.
Which kind of capture is this, PM4 / gfxr? Or is it meant to encompass both?
There was a problem hiding this comment.
Actually, it's PM4 capture. We are going to replace the current gRPC implementation, which only performs PM4 capture when using the server. We can discuss Gfxr capture using sockets once this implementation is complete. I've updated the naming to be explicit (e.g., PM4_CAPTURE_REQUEST). Thanks for pointing this out.
elviscapiaq
dismissed stale reviews from wangra-google and RenfengLiu
via
0842b42
- Messages (Request/Response) were added for the socket connection. - Helper functions for messages were added.
