-
Notifications
You must be signed in to change notification settings - Fork 63
[b456377401] Refactor Cloudera Manager authentication #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dominik-burdzy
merged 1 commit into
main
from
feature/b456377401/cloudera-clients-separation
Jan 26, 2026
Merged
[b456377401] Refactor Cloudera Manager authentication #1062
dominik-burdzy
merged 1 commit into
main
from
feature/b456377401/cloudera-clients-separation
Jan 26, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dominik-burdzy
commented
Jan 23, 2026
- Replace ClouderaManagerLoginHelper with ClouderaHttpClientFactory to manage both session-based (Cloudera Manager) and basic-auth (Knox/YARN) HTTP clients.
- Update ClouderaManagerHandle to manage separate clients for different authentication needs, ensuring correct credentials are used for both CM and cluster services.
- Update Cloudera Manager tasks and tests to utilize the refactored HTTP client management and ensure proper resource cleanup.
c1ad344 to
63caa11
Compare
Code Coverage Report
|
zaldis
reviewed
Jan 23, 2026
.../edwmigration/dumper/application/dumper/connector/cloudera/manager/ClouderaClustersTask.java
Outdated
Show resolved
Hide resolved
zaldis
reviewed
Jan 23, 2026
...igration/dumper/application/dumper/connector/cloudera/manager/ClouderaHttpClientFactory.java
Show resolved
Hide resolved
zaldis
reviewed
Jan 23, 2026
...edwmigration/dumper/application/dumper/connector/cloudera/manager/ClouderaManagerHandle.java
Outdated
Show resolved
Hide resolved
zaldis
reviewed
Jan 23, 2026
...edwmigration/dumper/application/dumper/connector/cloudera/manager/ClouderaManagerHandle.java
Outdated
Show resolved
Hide resolved
47aaef2 to
6915744
Compare
1. Replace ClouderaManagerLoginHelper with ClouderaHttpClientFactory to manage both session-based (Cloudera Manager) and basic-auth (Knox/YARN) HTTP clients. 2. Update ClouderaManagerHandle to manage separate clients for different authentication needs, ensuring correct credentials are used for both CM and cluster services. 3. Update Cloudera Manager tasks and tests to utilize the refactored HTTP client management and ensure proper resource cleanup.
6915744 to
2b184c7
Compare
zaldis
approved these changes
Jan 26, 2026
Member
zaldis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.