Block deprecated option for SF Assessment #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
misolt
commented
Aug 22, 2025
misolt
commented
- The option query_logs_earliest_timestamp is not supported for Snowflake Assessment. Make it throw an exception if enabled together with assessment mode.
- Move a few lines from addTasksTo to a helper.
misolt
requested review from
shevek-google and
vladislav-sidorovich
as code owners
...oogle/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeLogsConnector.java
Outdated
Show resolved
Hide resolved
vladislav-sidorovich
previously requested changes
Aug 26, 2025
Member
vladislav-sidorovich
left a comment
vladislav-sidorovich
left a comment
There was a problem hiding this comment.
I like the intention of the changes. Please move the logic to the validation method and we can go with it.
vladislav-sidorovich
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.